fix(types/index.d.ts): include padding parameter in fitBounds call signature#766
Open
Asvarox wants to merge 1 commit intotomchentw:masterfrom
Open
fix(types/index.d.ts): include padding parameter in fitBounds call signature#766Asvarox wants to merge 1 commit intotomchentw:masterfrom
Asvarox wants to merge 1 commit intotomchentw:masterfrom
Conversation
sunaurus
suggested changes
Mar 8, 2018
sunaurus
left a comment
sunaurus
left a comment
There was a problem hiding this comment.
The type of padding should actually be number|Padding as per https://developers.google.com/maps/documentation/javascript/reference/3.exp/map#Map.fitBounds
|
@tomchentw Why is this not merged yet? |
|
Created a new PR with the correct types: #906 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per https://developers.google.com/maps/documentation/javascript/reference . Noticed it when rewriting one of the components to TypeScript lighted up all the usages of this method.